Refactor consolidate skip options by ankalago · Pull Request #116 · Gentleman-Programming/Gentleman.Dots

ankalago · 2026-01-26T09:02:41Z

This pull request adds first-class support for AI coding assistants (OpenCode, Kilo Code, Continue.dev, and Aider) to the installer, documentation, and configuration workflow. Users can now select AI assistants during installation (both TUI and non-interactive modes), and the documentation has been updated to reflect these new options, including step-by-step installation instructions and skill management. The changes also introduce selective installation for all components, allowing users to skip steps and preserve their existing setups.

Installer Enhancements:

Added --ai flag to the installer CLI for specifying AI assistants to install (opencode, kilocode, continue, aider), including validation and integration with user choices in non-interactive mode (main.go). [1] [2] [3] [4] [5] [6] [7]
Updated config path detection to recognize new AI assistant config directories (opencode, kilocode, continue).

Documentation Updates:

Updated README.md and README.es.md to list supported AI assistants, describe their features/status, and explain selective installation. [1] [2] [3] [4] [5] [6]
Expanded the manual installation guide with detailed steps for installing and configuring each AI assistant, including copying skills and available skill descriptions. [1] [2] [3]

TUI Installer Workflow:

Added a dedicated step for selecting AI coding assistants in the TUI installer, supporting multi-selection and skip options. Clarified keyboard shortcuts and updated step numbering. [1] [2] [3] [4]
Documented AI assistant installation flow, skills directory management, and both interactive and non-interactive usage in the TUI installer guide. [1] [2] [3]

Selective Installation:

Introduced "Skip this step" options for each configuration phase, allowing users to install only specific components and preserve existing configurations. [1] [2]

Skill Management:

Standardized and documented the process for copying and loading AI assistant skills from the GentlemanClaude/skills/ directory for all supported assistants. [1] [2] [3] [4]

Screenshots

## Critical Bugs Fixed ### 1. Navigation Backwards Not Updating Summary (CRITICAL) - **Bug**: When user navigates back and changes selections, summary doesn't update - **Impact**: Wrong configs could be installed, user sees incorrect summary - **Root Causes**: 1. SkippedSteps flag not cleared when user makes real selection 2. Selections wiped when pressing ESC to go back **Fixes**: - Added `m.SkippedSteps[Screen] = false` when user makes selection (update.go, update_ai.go) - Removed all choice clearing in `goBackInstallStep()` - preserve selections - Only clear choices when going back to MainMenu (complete restart) **Test**: navigation_backwards_test.go (300+ lines) - Reproduces exact user scenario: skip all → select AI → go back → select Shell/Terminal - Verifies summary shows new selections, not skipped items ### 2. Installation Complete Screen Missing Info (CRITICAL) - **Bug**: Final summary doesn't show AI Assistants, status icons, or handle skipped shell - **Impact**: User sees incomplete summary, broken 'exec' command - **Problems**: 1. No AI Assistants in final summary 2. No ✓/✗ status icons 3. Shows empty values ("Terminal:", "Shell:") 4. Shows "exec" without shell name when skipped 5. Doesn't use GetInstallationSummary() - duplicated logic **Fixes**: - Refactored renderComplete() to use GetInstallationSummary() (single source of truth) - Added color-coded status: ✓ (green), ✗ (muted) - Only shows 'exec shell' if shell was actually installed - Shows generic message when shell skipped **Tests**: complete_screen_test.go (410 lines, 9 test cases) - Full installation, only AI, multiple AI, nushell→nu conversion - Terminal with/without font, all skipped, mixed selections ### 3. AI Assistants Config Detection Missing - **Bug**: Doesn't detect existing OpenCode/Continue.dev configs for backup - **Impact**: User doesn't see what will be overwritten (trust issue) **Fixes**: - Added AI paths to ConfigPaths(): opencode, kilocode, continue (system/exec.go) - Added AI cases to GetConfigsToOverwrite() with sliceContains() helper (model.go) - Only shows AI configs that user actually selected **Tests**: ai_configs_detection_test.go (190 lines, 4 test cases) - OpenCode only, AI skipped, multiple AI, AI + Shell mix ## New Features ### AI Assistants Support - New screen: ScreenAIAssistants with multi-select - Support for: OpenCode (available), Kilo Code (coming), Continue.dev (coming), Aider (coming) - Auto-configures skills from GentlemanClaude/skills/ - Integration with backup system **Files**: ai_assistants.go, update_ai.go ### Enhanced Testing - navigation_backwards_test.go - 300+ lines - complete_screen_test.go - 410 lines (9 comprehensive tests) - ai_configs_detection_test.go - 190 lines (4 edge cases) - installation_summary_test.go - Tests for GetInstallationSummary() - navigation_flow_test.go - E2E navigation tests - breadcrumb_test.go - Breadcrumb display tests **Total new test lines: ~900** ## Files Changed ### Core Logic - installer/internal/system/exec.go - Added AI config paths - installer/internal/tui/model.go - Added GetConfigsToOverwrite() AI cases, sliceContains() - installer/internal/tui/update.go - Fixed navigation backwards, clear skip flags - installer/internal/tui/update_ai.go - NEW: AI Assistants screen handler - installer/internal/tui/view.go - Refactored renderComplete() - installer/internal/tui/ai_assistants.go - NEW: AI assistant definitions ### Tests (6 new files) - installer/internal/tui/navigation_backwards_test.go - NEW - installer/internal/tui/complete_screen_test.go - NEW - installer/internal/tui/ai_configs_detection_test.go - NEW - installer/internal/tui/installation_summary_test.go - NEW - installer/internal/tui/navigation_flow_test.go - NEW - installer/internal/tui/breadcrumb_test.go - NEW ### Golden Tests (4 updated) - testdata/TestBackupScreenGolden.golden - testdata/TestCompleteScreenGolden.golden - testdata/TestMainMenuGolden.golden - testdata/TestOSSelectGolden.golden ### Documentation - README.md - Added AI Assistants section, selective installation docs - README.es.md - Spanish translation updates - docs/tui-installer.md - AI Assistants documentation - docs/manual-installation.md - AI setup instructions ## Test Results ✅ All tests pass (13.5s) ✅ 900+ lines of new test coverage ✅ No regressions detected ✅ Golden tests updated ## Breaking Changes None - backward compatible Closes #[issue-number-if-exists]

…on files to `.gitignore`.

…tent UX Remove redundant 'None' options from Terminal, Window Manager, and Neovim selection screens. Users now have a single, clear way to skip any step using '⏭️ Skip this step'. Changes: - Remove 'None' from Terminal options (macOS: 8→7, Linux: 7→6 options) - Remove 'None' from Window Manager options (6→5 options) - Remove 'No, skip Neovim' from Neovim options (7→6 options) - Simplify GetInstallationSummary() logic (remove 'none' checks) - Simplify terminal selection handler (remove 'none' conditional) - Update all tests to use 'Skip this step' instead of 'None' - Update installation_steps_test.go to use empty string for skip Benefits: - Clearer UX: Single consistent way to skip across all screens - Simpler code: Fewer special cases and conditionals - Better maintainability: Less cognitive load for developers Tests: All key tests passing, golden tests verified, builds successfully

Alan-TheGentleman

Hey Paul! Thanks for this comprehensive PR 👏 The AI assistants feature and skip options are great additions.

Tests Failing

Some tests are failing, please fix before merge:

FAIL: TestEachTerminalSelection/mac/none - Expected terminal=none, got ""
FAIL: TestEachTerminalSelection/linux/none - Expected terminal=none, got ""
FAIL: TestEachWMSelection/none - Expected wm=none, got ""
FAIL: TestNavigationBackwardsAndChangeSelection - Expected ScreenNvimSelect, got LearnNvim
FAIL: TestMainMenuGolden - Missing "🔄 Restore from Backup" in menu

AI Assistants Screen - Conditional Logic

Currently Claude Code installs automatically with Neovim (required for AI features). The screen needs conditional behavior:

If user SELECTED Neovim:

Show note: "ℹ️ Claude Code is installed automatically with Neovim (required for AI features)"
Claude Code should NOT appear in the list (already installed)
Add link/button to open docs/ai-configuration.md (explains how to switch AI plugins in Neovim)

If user SKIPPED Neovim:

Claude Code SHOULD appear as an optional item in the list
No link to AI docs (it's Neovim-specific)

Opening URLs from Bubbletea

import "os/exec"

func openURL(url string) error {
    switch runtime.GOOS {
    case "darwin":
        return exec.Command("open", url).Start()
    case "linux":
        return exec.Command("xdg-open", url).Start()
    }
    return nil
}

One more thing!

We also have gemini.lua in Neovim plugins. Would be good to add Gemini CLI to the AI assistants list as well for consistency.

Current Neovim AI plugins:

claude-code.lua ✅ (required with Neovim)
opencode.lua ✅ (in your list)
gemini.lua ❌ (missing from list)
copilot.lua (needs subscription, maybe skip?)
avante.lua (multi-provider, maybe skip?)

At minimum, Gemini CLI should be an option since we have the Neovim plugin for it.

And GitHub Copilot CLI too! We have copilot.lua and copilot-chat.lua plugins.

So the full list of AI assistants to consider:

Claude Code ✅
OpenCode ✅
Gemini CLI
GitHub Copilot CLI

These are the ones with both CLI + Neovim plugin integration.

Summary

Fix the 5 failing tests
If Neovim selected → show Claude Code note + link to AI docs
If Neovim skipped → list Claude Code as optional, no docs link
Add Github Copilot CLI
Add Gemini CLI

Let me know if you have questions! 🚀

Remove test cases for 'none' option in terminal and WM tests since these options no longer exist. Update cursor indices in navigation test to account for removed options. Fixes: - TestEachTerminalSelection: Remove 'none' test cases for mac/linux - TestEachWMSelection: Remove 'none' test case - TestNavigateBackwardsAndChangeSelection: Update cursor indices - WM skip: 4→3 (after removing 'None') - Nvim skip: 3→2 (after removing 'No, skip Neovim') All tests now pass successfully.

…on Neovim selection - Add Claude Code to AI assistants list with RequiresNvim flag - Show informational note when Neovim is selected explaining Claude Code is automatic - Hide Claude Code from selectable options when Neovim is installed - Add 'View AI Configuration Docs' link when Neovim is selected (opens in browser) - Skip non-selectable items (info notes, blank lines) in navigation - Fix toggle bug: AI assistants can now be selected/deselected correctly with Space - Fix duplicate Claude Code in installation summary - Add openURL() utility function for cross-platform URL opening - Update view rendering to style informational notes as non-selectable - Add comprehensive tests for conditional behavior and toggle functionality Resolves feedback: AI screen now adapts based on whether user selected or skipped Neovim

The informational note detection was too broad - it was treating ALL items starting with ℹ️ emoji as non-selectable, which broke 'Learn about terminals', 'Learn about shells', etc. Changes: - Restrict non-selectable detection to AI Assistants screen only - Use specific pattern 'ℹ️ Note:' instead of generic 'ℹ️' prefix - Update navigation logic in update_ai.go to match - Add comprehensive tests for all 'Learn about...' options Now 'Learn about...' items are properly selectable and highlighted when cursor is on them (yellow), while keeping AI screen info notes non-selectable (gray).

…Neovim installation and update related tests and summary output.

ankalago added 3 commits January 25, 2026 02:08

feat: Add gentleman-dots build output and common editor configurati…

fc95f77

…on files to `.gitignore`.

Alan-TheGentleman requested changes Jan 27, 2026

View reviewed changes

ankalago added 4 commits January 28, 2026 19:15

feat: Implement conditional display of AI assistant options based on …

2274ab8

…Neovim installation and update related tests and summary output.

ankalago requested a review from Alan-TheGentleman February 4, 2026 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor consolidate skip options#116

Refactor consolidate skip options#116
ankalago wants to merge 7 commits intoGentleman-Programming:mainfrom
ankalago:refactor/consolidate-skip-options

ankalago commented Jan 26, 2026 •

edited

Loading

Uh oh!

Alan-TheGentleman left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ankalago commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alan-TheGentleman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Tests Failing

AI Assistants Screen - Conditional Logic

If user SELECTED Neovim:

If user SKIPPED Neovim:

Opening URLs from Bubbletea

One more thing!

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ankalago commented Jan 26, 2026 •

edited

Loading

Alan-TheGentleman left a comment •

edited

Loading